Add extended address field #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fill script is generated by taking into accounts : - the cipher itself (login, card, contact) - the fields of the cipher For some reason, we added every contact field in the fields of the cipher. So the autofill function sometimes try to autofill the same HTML field two times : one because there is a match with the contact and one because there is a match with the same value in fields. We fix this by skipping fields during contact autofill.
zatteo
force-pushed
the
feat/add-extended-address-field
branch
from
e703f55
to
091bafc
Compare
Merkur39
approved these changes
Sep 26, 2024
| * @returns {AutofillScript} | ||
| * @private | ||
| */ | ||
| private async generateContactFillScript( |
There was a problem hiding this comment.
s/generateContactFillScript/generateContactAddressFillScript ?
- Lieu dit - Étage - Batiment - Escalier - Appartement - Code d'entrée Dictionary is very simple for the moment but it is enough for our test site.
zatteo
force-pushed
the
feat/add-extended-address-field
branch
from
091bafc
to
91fc438
Compare
zatteo
changed the base branch from
feat/no-double-autofill
to
feat/stream2-part3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In autofill and contact view
Tested on demande-logement-social.gouv.fr